Add more input types to LoginUpdateProfile#992
Open
Huber1 wants to merge 10 commits intokeycloakify:mainfrom
Open
Add more input types to LoginUpdateProfile#992Huber1 wants to merge 10 commits intokeycloakify:mainfrom
Huber1 wants to merge 10 commits intokeycloakify:mainfrom
Conversation
Change npmInstall to support array for lock file names
Contributor
📝 WalkthroughWalkthroughAdded three Storybook stories in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@stories/login/pages/LoginUpdateProfile.stories.tsx`:
- Around line 126-142: The attribute entry uses the key cardId but its name
property is "divison" (typo) which must match keys derived from attribute.name;
fix by making the object consistent: either rename the name property to "cardId"
(if this attribute represents a card ID) or rename the key from cardId to
"division" and correct the typo to "division" (if it represents a division);
update any related displayName or references to match the chosen canonical name
(look for the cardId key and the name property "divison" in
LoginUpdateProfile.stories.tsx).
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@stories/login/pages/LoginUpdateProfile.stories.tsx`:
- Around line 56-68: The select options for the favouritePet field don't match
the stored selected value(s): update the favouritePet configuration so the
options' values align with the stored value/value array (either change the
options array to ["dog","cat","bird"] or change value and values to
"Dog"/["Dog"]) so the preselect works; apply the same fix to the second
occurrence around the other favouritePet block referenced (match the options
array to the value/values or vice versa).
Comment on lines
+56
to
+68
| favouritePet: { | ||
| validators: { | ||
| options: { | ||
| options: ["Cat", "Dog", "Bird"] | ||
| } | ||
| }, | ||
| displayName: "Favourite Pet", | ||
| annotations: { | ||
| inputType: "select" | ||
| }, | ||
| value: "dog", | ||
| values: ["dog"], | ||
| name: "favouritePet" |
Contributor
There was a problem hiding this comment.
Align select option values with selected value(s).
favouritePet uses value(s) "dog" while options are ["Cat","Dog","Bird"]. If the component matches strictly, the preselect won’t show. Consider matching case or using option values that align with the stored value.
Proposed fix (match displayed options)
- value: "dog",
- values: ["dog"],
+ value: "Dog",
+ values: ["Dog"],- value: "dog",
+ value: "Dog",Also applies to: 112-123
🤖 Prompt for AI Agents
In `@stories/login/pages/LoginUpdateProfile.stories.tsx` around lines 56 - 68, The
select options for the favouritePet field don't match the stored selected
value(s): update the favouritePet configuration so the options' values align
with the stored value/value array (either change the options array to
["dog","cat","bird"] or change value and values to "Dog"/["Dog"]) so the
preselect works; apply the same fix to the second occurrence around the other
favouritePet block referenced (match the options array to the value/values or
vice versa).
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@stories/login/pages/LoginUpdateProfile.stories.tsx`:
- Around line 161-177: The attribute object keyed as "division" has a typo in
its internal name property ("divison"); update the attribute's name property in
the object (the one currently set to "divison") to "division" so the key and
attribute.name match the project's pattern (look for the attribute object with
key division and field name/name property to correct).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello guys,
I added some more input types to LoginUpdateProfile.
The values for kcContext are taken from the browser console on a real keycloak instance
Looks like this:
I also added a group.
in my custom theme, this renders correctly:
For reasons i do not understand, the
GroupLabelcomponent inUserProfileFormFieldsis not rendered (without error) in this repo, only on my custom theme, even though i didn't change the structure (all theifs and stuff still exist like before).That's the reason I included it here.
If that's a problem, i can remove the sections
Summary by CodeRabbit