refactor(pxe)!: combine dhcpd and tftpd to dnsmasq#69
Merged
khuedoan merged 25 commits intokhuedoan:masterfrom Jul 17, 2022
Merged
refactor(pxe)!: combine dhcpd and tftpd to dnsmasq#69khuedoan merged 25 commits intokhuedoan:masterfrom
khuedoan merged 25 commits intokhuedoan:masterfrom
Conversation
Bourne-ID
commented
Jul 10, 2022
Contributor
Author
|
Missing: Documentation. Open for implementation review. |
Owner
|
Thanks! I'll test this on my metal nodes soon 😄 |
khuedoan
reviewed
Jul 17, 2022
Owner
khuedoan
left a comment
There was a problem hiding this comment.
I've tested this on my metal3 node and it works flawlessly!
NAME STATUS ROLES AGE VERSION
metal3 Ready <none> 69s v1.23.6+k3s1
Thank you so much for this, just some comment on the default option and nitpicks:
Co-authored-by: Khue Doan <[email protected]>
Co-authored-by: Khue Doan <[email protected]>
Moving to use proxy by default Co-authored-by: Khue Doan <[email protected]>
Co-authored-by: Khue Doan <[email protected]>
Co-authored-by: Khue Doan <[email protected]>
Co-authored-by: Khue Doan <[email protected]>
Contributor
Author
|
I believe that's all comments addressed @khuedoan - let me know if I've missed anything! |
zanehala
added a commit
to zanehala/homelab
that referenced
this pull request
Apr 18, 2023
…from renovate/all-minor-patch into master Reviewed-on: https://git.zanelab.com/zhala/homelab/pulls/69
east4ming
pushed a commit
to east4ming/homelab2
that referenced
this pull request
Mar 15, 2025
…huedoan#69) from renovate/all-minor-patch into master Reviewed-on: https://git.west-beta.ts.net/ops/homelab2/pulls/69
east4ming
pushed a commit
to east4ming/homelab2
that referenced
this pull request
Jul 30, 2025
…huedoan#69) from renovate/all-minor-patch into master Reviewed-on: https://git.west-beta.ts.net/ops/homelab2/pulls/69
brimdor
pushed a commit
to brimdor/homelab
that referenced
this pull request
Apr 1, 2026
…er tag to v13' (khuedoan#69) from renovate/docker.io-library-debian-13.x into master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #70 for proposal linked to this PR