Add verbose config option#16
Merged
kieselsteini merged 3 commits intokieselsteini:masterfrom Jun 11, 2019
Merged
Conversation
Owner
|
Hello thank you for contributing. Thanks, Sebastian |
Owner
|
Added some documentation, adjusted the the config file and used a function for checking the value instead of strcasecmp (there might be some more "bool" options in future). |
Contributor
Author
|
Thanks! Good idea creating that function. Actually I realised it was a bool and thought about creating a macro or function for it as well, but then I wanted to leave that up to you for better integration with what you have in mind for future options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello and thanks for developing this amazing gopher client for all command line minimalists.
In its current state this client is just about perfect for me, with one small exception: me and some people I know that also use cgo would like to have a simple config option to make output less verbose, which is especially useful when the terminal has limited vertical real estate.
To this end I've committed a simple change on my local fork which adds a config option called verbose which the user can set to either true/on or false/off. Depending on the value, cgo will either display or hide messages like "downloading..." "executing..." which although useful might clutter the display. The default value is set to true, meaning this is opt-in.
You can see an illustration of verbose true on the left and verbose false on the right here:
https://i.imgur.com/3KvONWw.png
Feel free to accept/modify this pull request into your repo's master branch if you find this could be a useful option to add to this great client.
Thanks!