Skip to content

Update CHANGES.md for edge-19.5.3 release#2829

Merged
rmars merged 6 commits intomasterfrom
rmars/edge-19.5.3
May 16, 2019
Merged

Update CHANGES.md for edge-19.5.3 release#2829
rmars merged 6 commits intomasterfrom
rmars/edge-19.5.3

Conversation

@rmars
Copy link
Copy Markdown

@rmars rmars commented May 16, 2019

No description provided.

@rmars rmars self-assigned this May 16, 2019
@rmars rmars requested review from alpeb and scottcarol May 16, 2019 18:27
Copy link
Copy Markdown
Member

@olix0r olix0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments, otherwise good to go

Comment thread CHANGES.md Outdated
* Added Controller Component Labels to webhooks (thanks, @Pothulapati!)
* Moved the tap service into its own pod
* Proxy
* Upgraded mio to 0.6.17
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer: Fix an epoll notification issue that could cause excessive CPU usage

Comment thread CHANGES.md Outdated
* Proxy
* Upgraded mio to 0.6.17
* Allow disabling tap by setting an env var (thanks, @zaharidichev!)
* Added tests to ensure that outbound TLS works even when there is no verified
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not user facing, omit

Comment thread CHANGES.md Outdated
* Allow disabling tap by setting an env var (thanks, @zaharidichev!)
* Added tests to ensure that outbound TLS works even when there is no verified
certificate for the proxy yet (thanks, @zaharidichev!)
* Fall back to ORIG_DST when no endpoints exist
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not user facing, please omit

Comment thread CHANGES.md Outdated
* CLI
* **New** Added a `linkerd edges` command that shows TLS status
between src and dst resources
* Tap can now be disabled by using the `--disable-tap` flag
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be more specific on this, saying it can be disabled for specific pods during injection by ways of the --disable-tap flag, or its corresponding config.linkerd.io/disable-tap annotation.

Comment thread CHANGES.md Outdated
* Tap can now be disabled by using the `--disable-tap` flag
* Introduced pre-install healthcheck for clock skew (thanks, @matej-g!)
* Controller
* Added Controller Component Labels to webhooks (thanks, @Pothulapati!)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... to the webhook config resources

Comment thread CHANGES.md Outdated
## edge-19.5.3

* CLI
* **New** Added a `linkerd edges` command that shows TLS status
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're trying to differentiate between TLS and identity in general, so I think it would be better to say "Added a linkerd edges command that shows connections between src and dst resources and the identities of their Linkerd proxies. This will help users verify that Linkerd proxies have a known identity."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update, recommendation from @klingerf: "Added a linkerd edges command that shows the source and destination name and identity for proxied connections, to assist in debugging" I think that's more clear.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@l5d-bot
Copy link
Copy Markdown
Collaborator

l5d-bot commented May 16, 2019

Integration test results for 0a64fd5: success 🎉
Log output: https://gist.github.com/570d83aec9ed1952172fa39a86ce6193

Comment thread CHANGES.md Outdated
@rmars rmars merged commit 23c7a79 into master May 16, 2019
@rmars rmars deleted the rmars/edge-19.5.3 branch May 16, 2019 19:41
@l5d-bot
Copy link
Copy Markdown
Collaborator

l5d-bot commented May 16, 2019

Integration test results for c67ae64: fail 😕
Log output: https://gist.github.com/0d3340380c2eda71ee95f2666041e7cd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants