Stable 2.3.1 Release Notes by dadjeibaah · Pull Request #2869 · linkerd/linkerd2

dadjeibaah · 2019-05-30T21:07:14Z

This stable release adds a number of proxy stability improvements.

To install this release, run: curl https://run.linkerd.io/install | sh

Special thanks to: @zaharidichev and @11Takanori!

Full release notes:

Proxy
- Changed the proxy's routing behavior so that, when the control plane
  does not resolve a destination, the proxy forwards the request with minimal
  additional routing logic
- Fixed a bug in the proxy's HPACK codec that could cause requests with
  very large header values to hang indefinitely
- Replaced the fixed reconnect backoff with an exponential one (thanks,
  @zaharidichev!)
- Fixed an issue where requests could be held indefinitely by the load balancer
- Added a dispatch timeout that limits the amount of time a request can be
  buffered in the proxy
- Removed the limit on the number of concurrently active service discovery
  queries to the destination service
- Fixed an epoll notification issue that could cause excessive CPU usage
- Added the ability to disable tap by setting an env var (thanks,
  @zaharidichev!)

klingerf

Looks good, and I just had super nit picky formatting comments, but will defer to the proxy folks to approve the content.

klingerf · 2019-05-30T21:09:00Z

+  * Fixed a bug in the proxy's HPACK codec that could cause requests with
+    very large header values to hang indefinitely.
+  * Replaced the fixed reconnect backoff with an exponential one (thanks,
+      @zaharidichev!)


You can remove 2 leading spaces from this line, to match to formatting of the other bullet points.

klingerf · 2019-05-30T21:09:10Z

+    queries to the Destination service
+  * Fix an epoll notification issue that could cause excessive CPU usage
+  * Added the ability to disable tap by setting an env var (thanks,
+      @zaharidichev!)


Same goes for this line.

admc · 2019-05-30T21:16:03Z

+**Full release notes**:
+* Proxy
+  * Changed the proxy's routing behavior so that, when the control plane
+    does not resolve a destination, the proxy forwards request with minimal


should 'request' be plural?

scottcarol

nice! 🚢 🥇 2 minor nits

scottcarol · 2019-05-30T21:16:40Z

+**Full release notes**:
+* Proxy
+  * Changed the proxy's routing behavior so that, when the control plane
+    does not resolve a destination, the proxy forwards request with minimal


should this be proxy forwards the request?

scottcarol · 2019-05-30T21:16:53Z

+    does not resolve a destination, the proxy forwards request with minimal
+    additional routing logic
+  * Fixed a bug in the proxy's HPACK codec that could cause requests with
+    very large header values to hang indefinitely.


you can remove period from the end of this sentence

admc · 2019-05-30T21:18:34Z

+  * Added a dispatch timeout that limits the amount of time a request can be
+    buffered in the proxy
+  * Removed the limit on the number of concurrently active service discovery
+    queries to the Destination service


total nit, but Capitalization of "Destination service" seems strange, maybe either both caps or neither? If that is indeed correct, feel free to ignore.

I was curious about this too as I'm drafting edge release notes. Right now there are 3 "Destination service" mentions and 3 "destination service" mentions so Dennis I guess you are the tie-breaker? :)

This is too much pressure haha. No caps feels much better?

l5d-bot · 2019-05-30T21:24:19Z

Integration test results for 7b26b4b: success 🎉
Log output: https://gist.github.com/ad8841e3063dfacfd0dc984ca3adbfa0

dadjeibaah · 2019-05-30T21:37:01Z

Thanks for the feedback folks, changes coming up in the next commit.

l5d-bot · 2019-05-30T22:00:04Z

Integration test results for eb62737: success 🎉
Log output: https://gist.github.com/3824a744d87b89497f7952b30c11b7c1

hawkw · 2019-05-30T22:06:33Z

+
+* Proxy
+  * Changed the proxy's routing behavior so that, when the control plane
+    does not resolve a destination, the proxy forwards the request with minimal


IMO "forwards the request to its original destination" better describes the behaviour than "forwards the request with minimal additional routing logic".

I think "forwards the request with minimal additional routing logic" works because it implies there is more going on behind the scenes w.r.t routing and that the behavior has now been fixed.

hawkw · 2019-05-30T22:07:21Z

+    buffered in the proxy
+  * Removed the limit on the number of concurrently active service discovery
+    queries to the destination service
+  * Fix an epoll notification issue that could cause excessive CPU usage


This is in present tense, while it looks like all the other bullet points are in past-tense.

Suggested change

* Fix an epoll notification issue that could cause excessive CPU usage

* Fixed an epoll notification issue that could cause excessive CPU usage

olix0r · 2019-05-30T22:49:23Z

+    very large header values to hang indefinitely
+  * Replaced the fixed reconnect backoff with an exponential one (thanks,
+      @zaharidichev!)
+  * Fixed an issue where load balancers can become stuck


Perhaps: Fixed an issue where requests could be held indefinitely by the load balancer ?

"stuck" is a bit squishy

Sounds great. Thanks for the feedback.

l5d-bot · 2019-05-30T22:57:53Z

Integration test results for d890edf: success 🎉
Log output: https://gist.github.com/0697f9e8f7ab3c3c69b1702efc032213

l5d-bot · 2019-05-30T23:24:34Z

Integration test results for 2d9cfff: fail 😕
Log output: https://gist.github.com/fd3728fb4cd7c3d86aac46e5d298d732

wmorgan

Great!

alpeb

LGTM!

@zaharidichev

This stable release adds a number of proxy stability improvements. To install this release, run: `curl https://run.linkerd.io/install | sh` **Special thanks to**: @zaharidichev and @11Takanori! **Full release notes**: * Proxy * Changed the proxy's routing behavior so that, when the control plane does not resolve a destination, the proxy forwards the request with minimal additional routing logic * Fixed a bug in the proxy's HPACK codec that could cause requests with very large header values to hang indefinitely * Replaced the fixed reconnect backoff with an exponential one (thanks, @zaharidichev!) * Fixed an issue where requests could be held indefinitely by the load balancer * Added a dispatch timeout that limits the amount of time a request can be buffered in the proxy * Removed the limit on the number of concurrently active service discovery queries to the destination service * Fixed an epoll notification issue that could cause excessive CPU usage * Added the ability to disable tap by setting an env var (thanks, @zaharidichev!)

Dennis Adjei-Baah added 2 commits May 29, 2019 16:19

2.3.1 release notes

39d26a0

2.3.1 release notes

7b26b4b

dadjeibaah requested review from olix0r and scottcarol May 30, 2019 21:07

dadjeibaah requested review from admc, klingerf and wmorgan as code owners May 30, 2019 21:07

dadjeibaah self-assigned this May 30, 2019

klingerf reviewed May 30, 2019

View reviewed changes

admc reviewed May 30, 2019

View reviewed changes

scottcarol reviewed May 30, 2019

View reviewed changes

admc reviewed May 30, 2019

View reviewed changes

address PR feedback

eb62737

hawkw reviewed May 30, 2019

View reviewed changes

fix present tense bullet point

d890edf

olix0r reviewed May 30, 2019

View reviewed changes

change phrasing for load balancer fix

2d9cfff

scottcarol mentioned this pull request May 30, 2019

Update CHANGES.md for edge-19.5.4 release #2872

Merged

olix0r approved these changes May 30, 2019

View reviewed changes

wmorgan approved these changes May 31, 2019

View reviewed changes

alpeb approved these changes May 31, 2019

View reviewed changes

dadjeibaah merged commit c549b64 into master May 31, 2019

dadjeibaah deleted the dad/2.3.1-changelog branch May 31, 2019 15:59

	* Fix an epoll notification issue that could cause excessive CPU usage
	* Fixed an epoll notification issue that could cause excessive CPU usage

Conversation

dadjeibaah commented May 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

klingerf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

scottcarol left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

l5d-bot commented May 30, 2019

Uh oh!

dadjeibaah commented May 30, 2019

Uh oh!

l5d-bot commented May 30, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

l5d-bot commented May 30, 2019

Uh oh!

l5d-bot commented May 30, 2019

Uh oh!

wmorgan left a comment

Choose a reason for hiding this comment

Uh oh!

alpeb left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

dadjeibaah commented May 30, 2019 •

edited

Loading