Skip to content

Add packaging as explicit dependency#427

Merged
jwhite242 merged 4 commits intodevelopfrom
bugfix/packaging_version
Aug 23, 2023
Merged

Add packaging as explicit dependency#427
jwhite242 merged 4 commits intodevelopfrom
bugfix/packaging_version

Conversation

@jwhite242
Copy link
Copy Markdown
Collaborator

@jwhite242 jwhite242 commented Aug 23, 2023 •
edited
Loading

  • Adds packaging to toml file as it is now a required non-dev dependency. Version is constrained to >=22.0 to reflect removal of LegacyVersion which can be returned from parse_version in older packaging versions.
  • Improve robustness of flux adapter version error handling by testing against base_version to allow pre-release builds to succeed.
  • Add version comparison unit tests for both full and base_version variants

@jwhite242 jwhite242 added the Bugfix Discussion/Implementation of a solution to a bug (usually a PR) label Aug 23, 2023
@jwhite242 jwhite242 requested a review from doutriaux1 August 23, 2023 18:26
@jwhite242 jwhite242 merged commit 0442e1e into develop Aug 23, 2023
@jwhite242 jwhite242 deleted the bugfix/packaging_version branch August 23, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doutriaux1 doutriaux1 doutriaux1 approved these changes

Assignees

No one assigned

Labels

Bugfix Discussion/Implementation of a solution to a bug (usually a PR)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jwhite242 @doutriaux1