Skip to content

fix: SyntaxWarning: "is" with a literal. Did you mean "=="?#145

Merged
longld merged 1 commit intolongld:masterfrom
afq984:master
Jan 28, 2020
Merged

fix: SyntaxWarning: "is" with a literal. Did you mean "=="?#145
longld merged 1 commit intolongld:masterfrom
afq984:master

Conversation

@afq984
Copy link
Copy Markdown
Contributor

@afq984 afq984 commented Nov 28, 2019 •
edited
Loading

With python 3.8.0:

/usr/share/peda/peda.py:45: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if sys.version_info.major is 3:
/usr/share/peda/peda.py:5780: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if pyversion is 2:
/usr/share/peda/peda.py:5782: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if pyversion is 3:
/usr/share/peda/peda.py:5791: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if pyversion is 2:
/usr/share/peda/peda.py:5793: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if pyversion is 3:
/usr/share/peda/peda.py:5802: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if pyversion is 2:
/usr/share/peda/peda.py:5804: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if pyversion is 3:

The PR should fix it

@acut3
Copy link
Copy Markdown

acut3 commented Dec 16, 2019

Can someone merge this pull request?

This was referenced Jan 7, 2020
Merged
Open
@longld longld merged commit 0984243 into longld:master Jan 28, 2020
@r3k2
Copy link
Copy Markdown

r3k2 commented Jan 29, 2020

was just going to report this issue. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@afq984 @acut3 @r3k2 @longld