Merged
Conversation
…tify if FTL is already running to resolve a rare edge-case with reboot-persistent PID files and PID collisions. So far, this error has only been observed in certain docker configurations that lack the mandated PID file deletion after process shutdown With this new check, nothing changes in the "normal" case: ``` 2025-08-03 21:18:38.846 CEST [2803950M] INFO: pihole-FTL is already running (PID 1400358)! ``` However, if the PID actually belong to a different process (see described rare edge-case above), FTL does now not (incorrectly) stop any longer but merely logs ``` 2025-08-03 21:18:05.180 CEST [2803601M] WARNING: Found process "grep" at PID 1400357 suggested by PID file, ignoring ``` Signed-off-by: DL6ER <[email protected]>
6 tasks
yubiuser
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Also check name of process identified by PID file when trying to identify if FTL is already running to resolve a rare edge-case with reboot-persistent PID files and PID collisions. So far, this error has only been observed in certain docker configurations that lack the mandated PID file deletion after process shutdown
With this new check, nothing changes in the "normal" case:
However, if the PID actually belong to a different process (see described rare edge-case above), FTL does now not (incorrectly) stop any longer but merely logs
This PR has been sparked by pi-hole/docker-pi-hole#1789 (comment)
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentbranch.