Skip to content

Add timeout to curl command in branch validation#2011

Merged
PromoFaux merged 3 commits intopi-hole:developmentfrom
RynoCODE:master
Mar 29, 2026
Merged

Add timeout to curl command in branch validation#2011
PromoFaux merged 3 commits intopi-hole:developmentfrom
RynoCODE:master

Conversation

@RynoCODE
Copy link
Copy Markdown
Contributor

@RynoCODE RynoCODE commented Mar 27, 2026

Description

This pull request makes minor improvements to the build.sh script by improving error handling and reliability.

  • Bash script robustness:

    • Added set -e at the top of build.sh to ensure the script exits immediately if any command fails, improving error handling.
  • Network reliability:

    • Updated the curl command in the check_branch_exists function to include a --max-time 10 option, preventing the script from hanging indefinitely during network requests.

Motivation and Context

I was trying this build but I had some issues so I fixed it with simple error handling and exits on fail

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@RynoCODE RynoCODE requested a review from a team as a code owner March 27, 2026 13:50
@rdwebdesign
Copy link
Copy Markdown
Member

rdwebdesign commented Mar 27, 2026

You used master branch:

image

As asked on the template,

{Please select 'base: development' as target branch above! (you can delete this line)}

Please rebase your branch on development.


Also, can you please sign off your commit to satisfy the DCO bot requirement?

@RynoCODE
Copy link
Copy Markdown
Contributor Author

Hi @rdwebdesign , I've addressed all the requested changes — rebased on development, added DCO sign-off, and cleaned up the description. Please let me know if anything else is needed. Thanks!

@yubiuser yubiuser requested a review from rdwebdesign March 28, 2026 06:29
@PromoFaux PromoFaux merged commit 2bc31ae into pi-hole:development Mar 29, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants