Add timeout to curl command in branch validation#2011
Merged
PromoFaux merged 3 commits intopi-hole:developmentfrom Mar 29, 2026
Merged
Add timeout to curl command in branch validation#2011PromoFaux merged 3 commits intopi-hole:developmentfrom
PromoFaux merged 3 commits intopi-hole:developmentfrom
Conversation
Signed-off-by: GitHub <[email protected]>
Contributor
Author
|
Hi @rdwebdesign , I've addressed all the requested changes — rebased on development, added DCO sign-off, and cleaned up the description. Please let me know if anything else is needed. Thanks! |
yubiuser
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request makes minor improvements to the
build.shscript by improving error handling and reliability.Bash script robustness:
set -eat the top ofbuild.shto ensure the script exits immediately if any command fails, improving error handling.Network reliability:
curlcommand in thecheck_branch_existsfunction to include a--max-time 10option, preventing the script from hanging indefinitely during network requests.Motivation and Context
I was trying this build but I had some issues so I fixed it with simple error handling and exits on fail
Types of changes
Checklist: