Skip to content

Issue on page /mastering-plone/features.html - unclear task is solved#958

Closed
Thanush-03 wants to merge 3 commits intoplone:mainfrom
Thanush-03:thanush/948
Closed

Issue on page /mastering-plone/features.html - unclear task is solved#958
Thanush-03 wants to merge 3 commits intoplone:mainfrom
Thanush-03:thanush/948

Conversation

@Thanush-03
Copy link
Copy Markdown

@Thanush-03 Thanush-03 commented Aug 19, 2025

What I changed:

Added clear backend navigation steps in docs/mastering-plone/features.md under “Configure a mail server”:
How to reach Site Setup from the frontend.
Direct backend URL (http://localhost:8080/Plone) and where to click (Mail).
Added instructions to enable the add-on:
Go to Add-ons in Site Setup and activate Printing Mail Host (Products.PrintingMailHost).
Kept the training guidance that emails are shown in the console and to use “Save and send test e‑mail” to verify.

Why because

Removes ambiguity for beginners switching from frontend to backend.
Ensures users know where to configure mail and how to make Products.PrintingMailHost effective.

Scope
Only docs/mastering-plone/features.md was edited; no other files required changes.


📚 Documentation preview 📚: https://plone-training--958.org.readthedocs.build/

Copy link
Copy Markdown
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these changes are necessary. The UI is similar enough between both frontend and backend.

Copy link
Copy Markdown
Member

@ksuess ksuess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By now there is no "Save and send test e-mail" in the mail control panel of Volto.
But it is in Classic UI: http://localhost:8080/Plone/@@mail-controlpanel
This is why the user should be pointed to http://localhost:8080/Plone/@@mail-controlpanel for verifying she has the entries like being mentioned here and that mails are sent/printed to console.

You may want to use the following:
"With Products.PrintingMailHost, the training set up doesn't send mails, but prints them to the console."

The paragraph on enabling Products.PrintingMailHost in add-on control panel is wrong. It is patching Products.MailHost.MailHost. It is not an add-on to be installed or enabled.

@github-project-automation github-project-automation Bot moved this from New to In Progress in Plone Documentation Aug 20, 2025
@stevepiercy
Copy link
Copy Markdown
Contributor

@Thanush-03 would you please address the changes that @ksuess requested? Don't keep updating this branch to main only, which may be a final step before merging. Thank you!

@Thanush-03
Copy link
Copy Markdown
Author

ok, i will try to update the requested changes as soon as possible.
@ksuess mam, can you provide a screenshot of changes required.It may help easy to work on it.

@Thanush-03
Copy link
Copy Markdown
Author

Thanush-03 commented Aug 25, 2025

By now there is no "Save and send test e-mail" in the mail control panel of Volto. But it is in Classic UI: http://localhost:8080/Plone/@@mail-controlpanel This is why the user should be pointed to http://localhost:8080/Plone/@@mail-controlpanel for verifying she has the entries like being mentioned here and that mails are sent/printed to console.

You may want to use the following: "With Products.PrintingMailHost, the training set up doesn't send mails, but prints them to the console."

The paragraph on enabling Products.PrintingMailHost in add-on control panel is wrong. It is patching Products.MailHost.MailHost. It is not an add-on to be installed or enabled.

i unable to connect http://localhost:8080/Plone/@@mail-controlpanel this website what should i do now.it showing localhost refused to connect

@Thanush-03 Thanush-03 requested a review from ksuess August 25, 2025 02:20
@Thanush-03
Copy link
Copy Markdown
Author

By now there is no "Save and send test e-mail" in the mail control panel of Volto. But it is in Classic UI: http://localhost:8080/Plone/@@mail-controlpanel This is why the user should be pointed to http://localhost:8080/Plone/@@mail-controlpanel for verifying she has the entries like being mentioned here and that mails are sent/printed to console.

You may want to use the following: "With Products.PrintingMailHost, the training set up doesn't send mails, but prints them to the console."

The paragraph on enabling Products.PrintingMailHost in add-on control panel is wrong. It is patching Products.MailHost.MailHost. It is not an add-on to be installed or enabled.

mam i update requested changes just check it out. if some changes required just inform me.

@ksuess
Copy link
Copy Markdown
Member

ksuess commented Aug 25, 2025

@Thanush-03, if you want to learn Plone, please head over to the training https://training.plone.org
But please don't provide AI generated issue fixes.
I apologize if I am wrong, but it seems that you never set up a Plone site, nor set up the training set up of the Mastering Plone Development training.

@Thanush-03
Copy link
Copy Markdown
Author

i haven't given ai to fix. i only trying to understand the code space and trying to sort it out and as am fresher may be there will be wrong.While you told two changes i thought it as html paragraph changes required i change it with my sentence instead of copying your sentence and also i asked the screenshot what changes required as i didn't understand you not provided. I am sitting from a week to understand the code and the test data base. kindly help me to understand where the changes required and try to provide video if possible.
Thank you.

@stevepiercy
Copy link
Copy Markdown
Contributor

@Thanush-03 @ksuess would you please connect to resolve what, if anything, needs to be done for this open PR? I'm not clear myself.

If nothing needs to be done, then please close it as "won't fix". Thank you!

@ksuess
Copy link
Copy Markdown
Member

ksuess commented Sep 8, 2025

@Thanush-03 , I suggest you install the training setup. Then you see what I mean by my change requests https://github.com/plone/pull/pullrequestreview-3135560713.
To fix issues, it is necessary to be able to reproduce the problem.

I'm not willing to give you screenshots of obvious, decrypt your confused posts and ask what you mean, what you have installed and what you see when you do this and that.
If you want to correct the training material, install the training, follow the training and ask concretely what you are unclear. Then I like to help.

@ksuess
Copy link
Copy Markdown
Member

ksuess commented Sep 8, 2025

And for a review, please commit your locally made changes.

@ksuess
Copy link
Copy Markdown
Member

ksuess commented Sep 17, 2025

Superseeding by #967 as you did not commit your local changes.

@ksuess ksuess closed this Sep 17, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Plone Documentation Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants