Skip to content

Minor cleanups#175

Merged
NelsonVides merged 4 commits intomasterfrom
cleanups
Mar 9, 2025
Merged

Minor cleanups#175
NelsonVides merged 4 commits intomasterfrom
cleanups

Conversation

@NelsonVides
Copy link
Copy Markdown
Member

Splitting from #173, proposing a bunch of uncontroversial changes, in order to prepare a release soon.

This integrates some minor performance improvements and cleanups from
odo/quantile_estimator#8.
Note that OTP declares those with underscore infixes and 's suffixes
as deprecated.
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/metrics/prometheus_histogram.erl 95.74% <ø> (+6.91%) ⬆️
src/prometheus_time.erl 97.43% <100.00%> (ø)
test/eunit/metric/prometheus_histogram_tests.erl 98.22% <100.00%> (+0.17%) ⬆️
test/eunit/prometheus_time_tests.erl 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


from_native_test() ->
NativeInUS = erlang:convert_time_unit(1, micro_seconds, native),
NativeInUS = erlang:convert_time_unit(1, microsecond, native),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Comment thread src/metrics/prometheus_histogram.erl
@NelsonVides NelsonVides merged commit 36387e6 into master Mar 9, 2025
@NelsonVides NelsonVides deleted the cleanups branch March 9, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants