Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
mikpe
previously approved these changes
Feb 25, 2025
lhoguin
requested changes
Feb 26, 2025
DenysGonchar
previously approved these changes
Feb 26, 2025
Note that the underlying algorithm for quantiles is not mergeable, hence, it requires a linear strategy. However, precisely because it is not generally mergeable, and it is also expensive, Prometheus generally recommends using histograms on the client side, and it is left to the Prometheus server to compute, merge, and aggregate, histograms, recreating any required quantiles. It is left for the future to implement mergeable summaries, an idea would be a DDSketch algorithm or any variant thereof.
72579ed to
f1331e6
Compare
lhoguin
approved these changes
Feb 26, 2025
lhoguin
left a comment
There was a problem hiding this comment.
This review only validates that RabbitMQ should continue to work after this change. I have not evaluated the technical merits of quantile summaries (I'm out of my league there).
mikpe
approved these changes
Feb 26, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159 and #146
As in the last commit: