Skip to content

Run promtool in CI#188

Merged
NelsonVides merged 6 commits intomasterfrom
promtool
Jul 24, 2025
Merged

Run promtool in CI#188
NelsonVides merged 6 commits intomasterfrom
promtool

Conversation

@NelsonVides
Copy link
Copy Markdown
Member

@NelsonVides NelsonVides commented Jul 15, 2025

Fixes #135.

@NelsonVides NelsonVides self-assigned this Jul 15, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
.../collectors/mnesia/prometheus_mnesia_collector.erl 95.91% <100.00%> (ø)
src/collectors/prometheus_collectors_compat.erl 100.00% <100.00%> (ø)
...c/collectors/vm/prometheus_vm_memory_collector.erl 100.00% <100.00%> (ø)
...rc/collectors/vm/prometheus_vm_msacc_collector.erl 100.00% <ø> (ø)
...llectors/vm/prometheus_vm_statistics_collector.erl 92.59% <100.00%> (ø)
...lectors/vm/prometheus_vm_system_info_collector.erl 88.46% <100.00%> (+1.92%) ⬆️
src/contrib/prometheus_mnesia.erl 85.71% <ø> (ø)
src/formats/prometheus_protobuf_format.erl 100.00% <ø> (ø)
src/formats/prometheus_text_format.erl 96.20% <ø> (ø)
src/prometheus_time.erl 97.43% <ø> (ø)
... and 5 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NelsonVides NelsonVides force-pushed the promtool branch 11 times, most recently from 223b204 to 92647fc Compare July 15, 2025 06:51
Comment thread .github/workflows/main.yml Outdated
@NelsonVides NelsonVides force-pushed the promtool branch 3 times, most recently from 8fec3e2 to 2525a0b Compare July 15, 2025 10:59
Comment thread .github/workflows/main.yml Outdated
@NelsonVides NelsonVides force-pushed the promtool branch 2 times, most recently from 4dbbfd1 to ae32afd Compare July 21, 2025 10:59
@NelsonVides NelsonVides linked an issue Jul 21, 2025 that may be closed by this pull request
@NelsonVides NelsonVides force-pushed the promtool branch 6 times, most recently from 9ea85cd to 3c004cc Compare July 22, 2025 06:32
@NelsonVides NelsonVides marked this pull request as ready for review July 22, 2025 06:35
Comment thread .github/workflows/main.yml
Comment thread .github/workflows/main.yml Outdated
- run: rebar3 eunit
- run: rebar3 fmt --check
if: ${{ matrix.otp == '28' }}
- run: rebar3 ex_doc
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're moving stuff, I'd do this last, too.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which one you mean, ex_doc? Why so? 😄

Comment thread src/collectors/prometheus_collectors_compat.erl
@paulo-ferraz-oliveira
Copy link
Copy Markdown

It'd be nice (if you remember) if the Release Notes would mentions what needs to be changed, e.g., with a table "From > To" so it's easy to follow.

@NelsonVides
Copy link
Copy Markdown
Member Author

It'd be nice (if you remember) if the Release Notes would mentions what needs to be changed, e.g., with a table "From > To" so it's easy to follow.

Hmm... this repo has no CHANGELOG, so dunno, probably just the release notes in github will be enough? That one will surely do :)

@NelsonVides NelsonVides merged commit c314f68 into master Jul 24, 2025
5 checks passed
@NelsonVides NelsonVides deleted the promtool branch July 24, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Built-in collectors fail promtool linting

4 participants