Add prometheus_text_format:format_into/3#194
Closed
the-mikedavis wants to merge 1 commit intoprometheus-erl:masterfrom
the-mikedavis:md/format-into
Closed
Add prometheus_text_format:format_into/3#194the-mikedavis wants to merge 1 commit intoprometheus-erl:masterfrom the-mikedavis:md/format-into
prometheus_text_format:format_into/3#194the-mikedavis wants to merge 1 commit intoprometheus-erl:masterfrom
the-mikedavis:md/format-into
Conversation
This can be used to stream the formatted output, avoiding the buffering of `ram_file` in `format/1`. For example using this library with Cowboy, you could use `cowboy_req:stream_body/3` with the iodata passed to the formatting callback in order to avoid buffering.
Contributor
Author
|
I folded this into #196 since the changes overlap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be used to stream the formatted output, avoiding the buffering of
ram_fileinformat/1. For example using this library with Cowboy, you could usecowboy_req:stream_body/3with the iodata passed to the formatting callback in order to avoid buffering.Also see rabbitmq/rabbitmq-server#14885, rabbitmq/rabbitmq-server#14865
WIP as I'd like to gather some metrics on memory usage. Also this should probably be added to
prometheus_protobuf_formatfor consistency.