fix(jetstream): preserve deny_delete on KV updates#1
Open
sebholstein wants to merge 1 commit intomainfrom
Open
fix(jetstream): preserve deny_delete on KV updates#1sebholstein wants to merge 1 commit intomainfrom
sebholstein wants to merge 1 commit intomainfrom
Conversation
When preparing KV stream config for update, read existing stream settings and keep deny_delete unchanged. This prevents UpdateKeyValue/PrepareKeyValueConfig from implicitly enabling deny_delete on buckets created without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deny_deletefrom the existing stream when preparing KV configs for update.deny_deleteduringUpdateKeyValue/PrepareKeyValueConfigflows.deny_delete=false.Validation