chore: sync fork to v1.49.0 with qaze JetStream extensions#2
Open
sebholstein wants to merge 44 commits intomainfrom
Open
chore: sync fork to v1.49.0 with qaze JetStream extensions#2sebholstein wants to merge 44 commits intomainfrom
sebholstein wants to merge 44 commits intomainfrom
Conversation
…mer (nats-io#1966) Signed-off-by: Piotr Piotrowski <[email protected]>
…ats-io#1965) Signed-off-by: Piotr Piotrowski <[email protected]>
* [IMPROVED] Add publish subject validation Signed-off-by: Piotr Piotrowski <[email protected]> * [IMPROVED] Use adaptive validation depending on subject len Signed-off-by: Piotr Piotrowski <[email protected]> * [IMPROVED] Validate reply subject when using custom one Signed-off-by: Piotr Piotrowski <[email protected]> --------- Signed-off-by: Piotr Piotrowski <[email protected]>
* Revert "[IMPROVED] Add publish subject validation (nats-io#1974)" This reverts commit 97bfc32. * [IMPROVED] Add publish subject validation (nats-io#1974) This reverts commit 1839467. * Add option to skip subject validation Signed-off-by: Piotr Piotrowski <[email protected]> --------- Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Also add test case that checks that correct error is returned when no jetstream is avalilable on subscription. Signed-off-by: John Smith <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
correct inverted logic and a few minor cleanups in README
…ats-io#2009) * Fix comments and refactor validateConsumerName function * Run go fmt
…o#2007) Seems like three copy-paste errors in constant comments that don't match their actual purpose.
nats-io#2010) * Fix ErrOrderedConsumerReset comment and documentation typos * Run go fmt
Updated expected message count in test case.
…error messages (nats-io#2008) * Fix typos and improve comments in consumer_config.go * Run go fmt
…est (nats-io#2016) * Fix error message in test for expected attempts count * run go fmt
…tation (nats-io#2020) * Fix comments for clarity and consistency * run go fmt
nats-io#2022) Signed-off-by: Piotr Piotrowski <[email protected]>
…1958) Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
…etstream/README.md (nats-io#2005) Corrected typos and improved clarity in README.
nats-io#2013) Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
When preparing KV stream config for update, read existing stream settings and keep deny_delete unchanged. This prevents UpdateKeyValue/PrepareKeyValueConfig from implicitly enabling deny_delete on buckets created without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1.49.0.JetStream.PrepareKeyValueConfig(...)JetStream.PrepareObjectStoreConfig(...)deny_deletewhen preparing/updating KV stream config so KV edit/update does not implicitly flip it totrue.Validation
go test ./jetstream -run Testgo test -modfile=go_test.mod ./jetstream/test -run "TestUpdateKeyValue_PreserveExistingDenyDelete|TestUpdateKeyValue"