Skip to content

Windows dump_crash_context take reference to crash_context #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jake-Shadle merged 3 commits into from
Mar 17, 2025
Merged

Windows dump_crash_context take reference to crash_context #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5dc8fda
Windows dump_crash_context take reference to crash_context
Will-MingLun-Li Mar 14, 2025
f6d97c6
Fix lint
Jake-Shadle Mar 17, 2025
b3d6e98
Fix test
Jake-Shadle Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/linux/dumper_cpu_info/x86_mips.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ pub fn write_cpu_information(sys_info: &mut MDRawSystemInfo) -> Result<()> {
{
sys_info.processor_level = cpu_info_table[3].value as u16;
sys_info.processor_revision =
(cpu_info_table[1].value << 8 | cpu_info_table[2].value) as u16;
((cpu_info_table[1].value << 8) | cpu_info_table[2].value) as u16;
}
if !vendor_id.is_empty() {
let vendor_id = vendor_id.as_bytes();
Expand Down
4 changes: 2 additions & 2 deletions src/windows/minidump_writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ impl MinidumpWriter {
exception_code,
};

Self::dump_crash_context(cc, minidump_type, destination)
Self::dump_crash_context(&cc, minidump_type, destination)
}
}

Expand All @@ -149,7 +149,7 @@ impl MinidumpWriter {
/// is the responsibility of the caller to ensure that the pointer is valid
/// for the duration of this function call.
pub fn dump_crash_context(
crash_context: crash_context::CrashContext,
crash_context: &crash_context::CrashContext,
minidump_type: Option<MinidumpType>,
destination: &mut std::fs::File,
) -> Result<(), Error> {
Expand Down
2 changes: 1 addition & 1 deletion tests/windows_minidump_writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ fn dump_external_process() {

// SAFETY: We keep the process we are dumping alive until the minidump is written
// and the test process keep the pointers it sent us alive until it is killed
MinidumpWriter::dump_crash_context(crash_context, None, tmpfile.as_file_mut())
MinidumpWriter::dump_crash_context(&crash_context, None, tmpfile.as_file_mut())
.expect("failed to write minidump");

child.kill().expect("failed to kill child");
Expand Down
Loading