Use unified crash-context#17
Merged
msirringhaus merged 3 commits intorust-minidump:mainfrom Mar 16, 2022
Merged
Conversation
Merged
da144a2 to
2c95808
Compare
61e2bbd to
f5e2ba1
Compare
Collaborator
msirringhaus
left a comment
There was a problem hiding this comment.
Sorry, one more nit.
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #16 to use the
CrashContextfrom here as it allows a single crash context to be shared between different crates, without needing to rely onminidump-writeritself, and implements getcontext for targets that don't directly support it such as musl and android.Resolves: #4