Skip to content

Add initial Windows implementation #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gankra merged 37 commits into from
Apr 26, 2022
Merged

Add initial Windows implementation #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
adb7acc
Add first pass at windows minidump writer
Jake-Shadle Mar 24, 2022
f4253be
Remove assertion info, it is functionally useless
Jake-Shadle Mar 25, 2022
6e3333f
Always open process handle internally
Jake-Shadle Mar 29, 2022
612d1d4
Use published crash-context
Jake-Shadle Mar 29, 2022
f917d93
Fix tests
Jake-Shadle Mar 30, 2022
3522e42
Rename linux integration test
Jake-Shadle Mar 30, 2022
c99359b
Gate ptrace integration test
Jake-Shadle Mar 30, 2022
d92e807
Remove duplicate stream test
Jake-Shadle Mar 30, 2022
332241f
Move linux specific code to submodule
Jake-Shadle Mar 30, 2022
9cae5c9
Add missing feature
Jake-Shadle Mar 30, 2022
a21f94f
Add inproc dump test
Jake-Shadle Mar 30, 2022
ffc5bdb
Add external process dump test
Jake-Shadle Mar 30, 2022
01fe7f4
Well that's a bit annoying
Jake-Shadle Mar 30, 2022
2cecfe9
Minor cleanup
Jake-Shadle Mar 30, 2022
7fcb05a
Buffer should not be empty
Jake-Shadle Mar 30, 2022
fbe2374
Get CONTEXT on another thread
Jake-Shadle Mar 30, 2022
61341d7
Try to keep RtlCaptureContext from crashing
Jake-Shadle Mar 30, 2022
d48f8a9
Grasping at straws here
Jake-Shadle Mar 30, 2022
d9b2492
Just for shits and giggles
Jake-Shadle Mar 30, 2022
f7587be
Ugh
Jake-Shadle Mar 30, 2022
597e8b7
Use loop
Jake-Shadle Mar 30, 2022
1807a63
Trim string
Jake-Shadle Mar 30, 2022
df973a3
Use illegal instead, access violation is special
Jake-Shadle Mar 30, 2022
110e333
Don't pretend we have a CONTEXT record
Jake-Shadle Mar 30, 2022
97b20c4
Try GetThreadContext instead
Jake-Shadle Mar 30, 2022
b9a8592
Add windows test to GHA
Jake-Shadle Mar 30, 2022
7f5b7d7
Cancel in flight actions when new commits are pushed to PRs
Jake-Shadle Mar 30, 2022
30fce57
Note PR that implements pWrite for MINIDUMP_BREAKPAD_INFO
Jake-Shadle Apr 21, 2022
aa2e999
Update crash-context to 0.1
Jake-Shadle Apr 21, 2022
d163ae5
Fix bump to 0.1
Jake-Shadle Apr 21, 2022
c60c57b
Address feedback
Jake-Shadle Apr 22, 2022
7d927df
Tests: Pass PID of child process to parent
marti4d Apr 22, 2022
07526b5
Tests: Use CrashReason::from_windows_code for exception
marti4d Apr 22, 2022
15de6bd
Merge pull request #1 from marti4d/fix_test
Jake-Shadle Apr 23, 2022
79493f9
Address feedback
Jake-Shadle Apr 23, 2022
233322b
Downgrade to 0.34 to better align with ecosystem
Jake-Shadle Apr 25, 2022
0083d50
Cleanup
Jake-Shadle Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ on:
- github-actions
pull_request:

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
unit_tests:
name: Build sources
Expand All @@ -25,8 +29,8 @@ jobs:
- { os: ubuntu-latest, target: arm-unknown-linux-musleabi, use-cross: true }
- { os: ubuntu-latest, target: arm-linux-androideabi, use-cross: true }
- { os: ubuntu-latest, target: arm-unknown-linux-gnueabihf, use-cross: true }
- { os: windows-2022, target: x86_64-pc-windows-msvc, use-cross: false }
#- { os: macos-latest, target: x86_64-apple-darwin, use-cross: false }
#- { os: windows-latest, target: x86_64-pc-windows-msvc, use-cross: false }
steps:
- name: Checkout repository
uses: actions/checkout@v2
Expand Down
21 changes: 16 additions & 5 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ license = "MIT"
[dependencies]
byteorder = "1.3.2"
cfg-if = "1.0"
crash-context = "0.0.2"
crash-context = "0.1"
memoffset = "0.6"
minidump-common = "0.10"
scroll = "0.11"
Expand All @@ -23,9 +23,20 @@ memmap2 = "0.5"
[target.'cfg(any(target_os = "linux", target_os = "android"))'.dependencies]
nix = "0.23"

[target.'cfg(target_os = "windows")'.dependencies.windows-sys]
version = "0.34" # Latest is 0.35 (for now), but a vast majority of the ecosystem uses 0.34
features = [
# MiniDumpWriteDump requires...a lot of features
"Win32_Foundation",
"Win32_Storage_FileSystem",
"Win32_System_Diagnostics_Debug",
"Win32_System_Kernel",
"Win32_System_Memory",
# VerifierEnumerateResource and friends
"Win32_System_ApplicationVerifier",
# GetCurrentThreadId & OpenProcess
"Win32_System_Threading",
]

[dev-dependencies]
minidump = "0.10"

[patch.crates-io]
minidump = { git = "https://github.com/rust-minidump/rust-minidump" }
minidump-common = { git = "https://github.com/rust-minidump/rust-minidump" }
Loading