Remove the redundant MDExceptionCodeLinux enum and use the values from minidump-common instead#62
Conversation
…m minidump-common instead
|
So interesting, there seems to be a difference between 1.64 and 1.65 on Windows, I could build and test successfully on Windows with this PR on 1.64.0 but then switched to 1.65.0 and got the same crash as CI did, so at least it's fully reproducible. |
|
So it looks like the |
|
That function does magic stuff with the stack so it's possible LLVM is hitting some edge-case where it generates incompatible code. Anyway WDYT about that clippy warning? I suppose we could |
|
I just wanted to unblock this change for now so I silenced it, but I think before the next release of this crate it would be good to actually amp up the clippy lints and actually address all of them or at least have better reasoning for why certain ones get silenced since overall it makes things better. |
No description provided.