Merged
Conversation
Revert change to procfs-core since it is not release still
The name (erroneously?) can include the (deleted) suffix which broke the comparison
gabrielesvelto
requested changes
Jun 19, 2023
gabrielesvelto
requested changes
Jun 21, 2023
gabrielesvelto
approved these changes
Jun 21, 2023
Contributor
|
So we're done here, merging |
|
Hi all, just dropping a quick note to say that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates all dependencies, and reverts #80 until
procfs-coreis released. Requested in eminence/procfs#273.Also fixed the
test_merged_mappingswhich was failing on my machine due to the(deleted)suffix causing the path comparison to fail. It now just checks the beginning matches which should effectively be the same unless this crate's testing gets far more comprehensive in the future.