chore: Minor CI changes to exclude experiments from review#89
Merged
github-actions[bot] merged 1 commit intomainfrom Jan 31, 2026
Merged
chore: Minor CI changes to exclude experiments from review#89github-actions[bot] merged 1 commit intomainfrom
github-actions[bot] merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
✅ Approved
This PR makes sensible improvements to the Claude Code Review CI workflow.
Changes Reviewed:
- Setup Claude environment step - Creates
.claudeignoreto excludeexperiments/folder from reviews - Enhanced review prompt - Explicitly instructs Claude to read CLAUDE.md and use the
dddskill - Expanded allowed tools - Adds
Read,Glob,Grepto allowed tools for more thorough code reviews
Blocking Issues: None
Suggestions (non-blocking):
- Minor cleanup opportunity: The
mkdir -p ~/.claudecommand creates a directory that isn't actually used, since.claudeignoreis written to the repo root (current working directory). You could remove this line or add a comment clarifying why it's there. Not blocking since it's harmless.
DDD Review:
This is a CI/infrastructure change rather than domain code, so DDD principles don't apply directly. The change aligns with the project's documented policy to exclude experiments from review processes.
Security:
- No security concerns. The workflow properly restricts auto-merge to non-fork PRs.
- Tool permissions are appropriately scoped.
LGTM! 🚀
keeb
added a commit
that referenced
this pull request
Apr 11, 2026
validateModelPathReference called modelRegistry.get() without first awaiting ensureTypeLoaded(), so cross-model CEL expressions referencing lazy-registered types failed with a misleading "Unknown model type" error even though the type was registered and worked at execution time. Missed call site from PR #1063 (lazy per-bundle loading) — the execution path was wired up but the validation path was not. ensureTypeLoaded is a no-op on already-loaded types, so the perf win from lazy loading is preserved. Closes swamp-club #89. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.