docs: update vault and datastore skill testing refs with conformance suites#965
Merged
docs: update vault and datastore skill testing refs with conformance suites#965
Conversation
…suites Lead with conformance suites (the primary value for extension authors) rather than test doubles. Add examples for assertVaultExportConformance, assertVaultConformance, assertDatastoreExportConformance, assertLockConformance, and assertVerifierConformance. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
There was a problem hiding this comment.
Code Review
No blocking issues. This is a docs-only change to skill reference files that restructures testing guidance to lead with conformance suites — the primary value for extension authors.
Verified
- All referenced conformance functions (
assertDatastoreExportConformance,assertLockConformance,assertVerifierConformance,assertVaultExportConformance,assertVaultConformance) exist inpackages/testing/and are properly exported. - No code changes, so no test coverage or type-checking concerns.
- Import paths in the "In-Repo Extensions" sections correctly point to
../../packages/testing/mod.ts.
Suggestions
- The vault testing doc's "In-Repo Extensions" example only shows
assertVaultExportConformance— consider also showingassertVaultConformancefor parity with the datastore doc which shows bothassertDatastoreExportConformanceandassertLockConformance.
Looks good — clear improvement to the developer experience for extension authors. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
references/testing.mdto lead with conformance suites (the primary value for extension authors) instead of test doublesassertVaultExportConformance,assertVaultConformance,assertDatastoreExportConformance,assertLockConformance, andassertVerifierConformanceFollow-up to #963.
Test Plan
🤖 Generated with Claude Code