Merged
Conversation
Owner
|
Hey :) Thank you very much for all those commits, and sorry for responding so late. Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Rene,
first of all, thank you for this very nice library that provides so many DR methods. We at Siemens are currently using it in one of our internal research projects for creating an interactive 3D scatterplot showing projected values.
I think I found a few bugs in the UMAP implementation. When accessing the rho and non_zero_dist arrays, I think one has to use the 'value' property to access the correct value (see lines 91, 140, 151, 171, for example). Also, I think it's not necessary to write values using set_entry in lines 363-364 and 384-385, since the Matrix' row function already returns a TypedArray on the ArrayBuffer that contains the original matrices values (instead of a copy).
Also I changed the 'dot' function to directly work on the values of Matrix B (instead of copying them to a new array using the col-Method). I found this beneficial, especially when dealing with larger datasets.
I would be happy, if you could merge some of these changes into the main branch.
Best regards
Johannes Kehrer (from Siemens AG in Munich)