Support ExportSpecifier defined stories#556
Merged
Conversation
🦋 Changeset detectedLatest commit: a9465c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Owner
It should definitely work for multiple stories/specifiers. Also, tests need to be added. This is an interesting case: const joe = 'joe';
export { joe, joe as jim }Should parse out |
deeea17 to
64dc654
Compare
Contributor
Author
|
It now
It doesn't resolve the original AST node of what's being exported so it misses the "function/class/variable" check. |
Contributor
Author
|
@tajo Could you have another look, please? |
Owner
|
lgtm |
Merged
Contributor
Author
|
lgtmt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in response to #554
In my local testing it works, however it only works for the first story in the export list, is this what we want?
Otherwise I could probably loop but the code would be a bit more involved.