Skip to content

Add hmrHost and hmrPort to the ladle config#558

Merged
tajo merged 1 commit intotajo:mainfrom
gapark:allow-hmr-config-override
May 31, 2024
Merged

Add hmrHost and hmrPort to the ladle config#558
tajo merged 1 commit intotajo:mainfrom
gapark:allow-hmr-config-override

Conversation

@gapark
Copy link
Copy Markdown
Contributor

@gapark gapark commented Apr 16, 2024

Fixes #557

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 16, 2024

🦋 Changeset detected

Latest commit: 2eaa8a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
website Minor
@ladle/react Minor
example Patch
test-addons Patch
test-babel Patch
test-config Patch
test-config-ts Patch
test-css Patch
test-decorators Patch
test-playwright Patch
test-programmatic Patch
test-provider Patch
test-baseweb Patch
test-msw Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gapark gapark force-pushed the allow-hmr-config-override branch from b12b9a3 to 2eaa8a4 Compare May 17, 2024 17:28
@gapark
Copy link
Copy Markdown
Contributor Author

gapark commented May 17, 2024

@tajo I found some time this evening to go through and tidy this up a bit and test it.

I think it should be ready to merge now if you wouldn't mind giving me a review?

@tajo tajo merged commit 55de74a into tajo:main May 31, 2024
@tajo tajo mentioned this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vite HMR config does not override Ladle default config

2 participants