Skip to content

allow the face of the minions lighter to be customized#23

Closed
cburroughs wants to merge 2 commits intotarsius:masterfrom
cburroughs:face
Closed

allow the face of the minions lighter to be customized#23
cburroughs wants to merge 2 commits intotarsius:masterfrom
cburroughs:face

Conversation

@cburroughs
Copy link
Copy Markdown

For example, to make the lighter bold, or tweak the :height of a spiffy emoji.
Since minions-mode-line-modes already calls propertize, this can't already be
done be setting the lighter string to a "propertized" value, a face is needed.

For example, to make the lighter bold, or tweak the :height of a spiffy emoji.
Since minions-mode-line-modes already calls propertize, this can't already be
done be setting the lighter string to a "propertized" value, a face is needed.
Comment thread minions.el Outdated
@cburroughs cburroughs requested a review from tarsius September 11, 2019 19:14
@tarsius tarsius closed this in ca6a3e7 Sep 18, 2019
@tarsius
Copy link
Copy Markdown
Owner

tarsius commented Sep 18, 2019

I've done this differently. My approach is modeled after display-time-mail-face.

Copy link
Copy Markdown
Owner

@tarsius tarsius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good...

Ps: Without this there still was a "Your review has been requested." call to action at the top.

Pps: And when I wrote this review I got a "Your review was submitted on a closed pull request." warning. 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants