Add missing default argument values in patched_load_by_key_path#81
Merged
youkaichao merged 1 commit intothuml:masterfrom Apr 18, 2025
Merged
Add missing default argument values in patched_load_by_key_path#81youkaichao merged 1 commit intothuml:masterfrom
patched_load_by_key_path#81youkaichao merged 1 commit intothuml:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
===========================================
- Coverage 91.14% 60.89% -30.26%
===========================================
Files 10 10
Lines 1547 1547
===========================================
- Hits 1410 942 -468
- Misses 137 605 +468 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #80 by aligning the default argument values of
patched_load_by_key_pathwith the unpatchedload_by_key_pathfunction (see https://github.com/pytorch/pytorch/blob/v2.6.0/torch/_inductor/codecache.py#L2753--L2754).