Skip to content

Fix rendering defaultPath for jupyter workspace files#152

Open
mirceanis wants to merge 1 commit intoudacimak:masterfrom
mirceanis:bugfix/workspace-defaultPath
Open

Fix rendering defaultPath for jupyter workspace files#152
mirceanis wants to merge 1 commit intoudacimak:masterfrom
mirceanis:bugfix/workspace-defaultPath

Conversation

@mirceanis
Copy link
Copy Markdown

Description

Workspace file defaultPathis collected from configuration.blueprint.conf.defaultPath instead of configuration.blueprint.conf.defaultPath.defaultPath

Fixes #151

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I rendered udacity nd880 to check that the workspace render shows the Default file path correctly:

Screenshot 2020-05-24 at 20 43 46

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@mirceanis mirceanis force-pushed the bugfix/workspace-defaultPath branch from f1c7d68 to b72c72b Compare June 1, 2020 07:40
@debosmit-git
Copy link
Copy Markdown

Please merge this :)

@akhilesh-k
Copy link
Copy Markdown

Please merge. 👍

@debosmit-git
Copy link
Copy Markdown

I'm sure the git owner is AFK. This merge would fix such a great requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workspace default file path is not picked up from corresponding data.json

3 participants