Skip to content

Auction house v3#106

Merged
ECWireless merged 25 commits intomainfrom
auction-house-v3
Aug 23, 2024
Merged

Auction house v3#106
ECWireless merged 25 commits intomainfrom
auction-house-v3

Conversation

@Fluffy9
Copy link
Copy Markdown
Collaborator

@Fluffy9 Fluffy9 commented Aug 10, 2024

still working on error handling stuff, rest should be alright

@Fluffy9 Fluffy9 requested a review from ECWireless August 10, 2024 00:18
@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 10, 2024

@Fluffy9 is attempting to deploy a commit to the Raid Guild Team on Vercel.

To accomplish this, @Fluffy9 needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ultimate-dominion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 1:22am

ECWireless
ECWireless requested changes Aug 13, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ECWireless ECWireless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge feature, so this is just a first pass! Will go through functionality and validation-related stuff in the next one. But awesome job in shouldering a feature this large

Comment thread packages/contracts/src/interfaces/Structs.sol
Comment thread packages/client/src/Routes.tsx Outdated
Comment thread .gitignore Outdated
Comment thread .gitignore Outdated
Comment thread packages/client/src/pages/Auction.tsx Outdated
Comment thread packages/client/src/pages/Item.tsx Outdated
Comment thread packages/client/src/components/WalletDetailsModal.tsx Outdated
Comment thread packages/client/src/components/WalletDetailsModal.tsx Outdated
Comment thread packages/client/src/components/AuctionRow.tsx Outdated
Comment thread packages/client/src/pages/Item.tsx Outdated
@Fluffy9 Fluffy9 requested a review from ECWireless August 16, 2024 16:02
@ECWireless
Copy link
Copy Markdown
Collaborator

ECWireless commented Aug 21, 2024

These features will be added in a separate PR:

  • Replace Auction House class filters with something more appropriate
  • ERC721 support with tests for all cases
  • Move the approvals from the wallet details modal into a modal that pops up when you click to sell

ECWireless
ECWireless approved these changes Aug 23, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ECWireless ECWireless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging now, but we can iteratively make improvements over the next week.

@ECWireless ECWireless merged commit 077b6ce into main Aug 23, 2024
@ECWireless ECWireless deleted the auction-house-v3 branch August 23, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ECWireless ECWireless ECWireless approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fluffy9 @ECWireless