Skip to content

Layout#25

Merged
ECWireless merged 3 commits intomainfrom
feat/24-game-board-layout
Jun 5, 2024
Merged

Layout#25
ECWireless merged 3 commits intomainfrom
feat/24-game-board-layout

Conversation

@Fluffy9
Copy link
Copy Markdown
Collaborator

@Fluffy9 Fluffy9 commented Jun 5, 2024

Feeling pretty good about this one

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 5, 2024

@Fluffy9 is attempting to deploy a commit to the Raid Guild Team on Vercel.

To accomplish this, @Fluffy9 needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@Fluffy9 Fluffy9 requested a review from ECWireless June 5, 2024 02:48
Copy link
Copy Markdown
Collaborator

@ECWireless ECWireless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Besides the comments I made, the only other changes I would make are having everything change to the mobile version below md, rather than sm. Could you also do a quick pass at making the props in alphabetical order?

Comment thread packages/client/src/Routes.tsx Outdated
Comment thread packages/client/src/pages/GameBoard.tsx Outdated
Comment thread packages/client/src/pages/GameBoard.tsx Outdated
Comment thread packages/client/src/pages/GameBoard.tsx Outdated
Comment thread packages/client/src/pages/GameBoard.tsx Outdated
Comment thread packages/client/src/pages/GameBoard.tsx Outdated
@Fluffy9 Fluffy9 requested a review from ECWireless June 5, 2024 15:04
Comment thread packages/client/src/pages/GameBoard.tsx Outdated
@Fluffy9 Fluffy9 requested a review from ECWireless June 5, 2024 17:10
@ECWireless ECWireless merged commit 9a6661f into main Jun 5, 2024
@ECWireless ECWireless deleted the feat/24-game-board-layout branch June 5, 2024 17:14
@Fluffy9 Fluffy9 mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants