fix: soul drain death check for StatusEffect upfront damage#316
Merged
Conversation
…path StatusEffect branch in CombatSystem applied upfront spell damage (via _calculateStatusEffect) but never checked if it killed the defender. PhysicalDamage and MagicDamage branches both had `if (currentHp <= 0) defenderDied = true` but StatusEffect was missing it entirely. This caused damage_debuff spells (Soul Drain, Marked Shot, Expose Weakness, Entangle) to bring enemies to 0 HP without triggering the death flag, creating unkillable zombie enemies that fight forever. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
damage_debuffspells (Soul Drain, Marked Shot, Expose Weakness, Entangle) bring enemies to 0 HP but never set thediedflag — creating unkillable zombie enemiesRoot Cause
_calculateStatusEffectapplies upfront spell damage and clamps HP to 0, but the StatusEffect branch never setsactionOutcomeData.defenderDied = true. The PhysicalDamage and MagicDamage branches both had this check; StatusEffect was missing it.Test plan
forge buildpasses (exit 0)0xDc34...5678)SoulDrainKill.integration.t.sol) — needs local devnode🤖 Generated with Claude Code