Skip to content

feat: cellSize 4px for density/performance balance #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mokn merged 1 commit into from
Apr 9, 2026
Merged

feat: cellSize 4px for density/performance balance #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/client/src/components/CharacterInspectOverlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ export function CharacterInspectOverlay({
<CharacterViewer
race={character.race}
height={380}
cellSize={3}
cellSize={4}
autoReveal
equippedItems={viewerEquipment}
/>
Expand Down Expand Up @@ -275,7 +275,7 @@ export function CharacterInspectOverlay({
<CharacterViewer
race={character.race}
height={280}
cellSize={3}
cellSize={4}
autoReveal
equippedItems={viewerEquipment}
/>
Expand Down
2 changes: 1 addition & 1 deletion packages/client/src/components/pretext/game/BattleMonsterAscii.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export function BattleMonsterAscii({
ctx.clearRect(0, 0, width, height);
renderMonster(ctx, template, 0, 0, width, height, {
elapsed: defeated ? 0 : elapsed,
cellSize: 3,
cellSize: 4,
enable3D: false,
enableGlow: !defeated,
enableBgFill: true,
Expand Down
4 changes: 2 additions & 2 deletions packages/client/src/components/pretext/game/BattleSceneCanvas.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ export const BattleSceneCanvas = forwardRef<
if (template) {
renderMonster(ctx, template, monsterX, monsterY, monsterW, monsterH, {
elapsed: p.monsterDefeated ? 0 : elapsed,
cellSize: 3,
cellSize: 4,
enable3D: true,
enableGlow: !p.monsterDefeated,
enableBgFill: true,
Expand Down Expand Up @@ -594,7 +594,7 @@ export const BattleSceneCanvas = forwardRef<

renderMonster(ctx, playerTpl, playerX, playerY, playerW, playerH, {
elapsed: p.userDefeated ? 0 : elapsed,
cellSize: 3,
cellSize: 4,
enable3D: true,
enableGlow: !p.userDefeated,
enableBgFill: true,
Expand Down
2 changes: 1 addition & 1 deletion packages/client/src/components/pretext/game/CharacterViewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ type DragState = {
export function CharacterViewer({
race,
height = 280,
cellSize = 3,
cellSize = 4,
autoReveal = false,
equippedItems,
// Legacy single-weapon prop (use equippedItems instead)
Expand Down
2 changes: 1 addition & 1 deletion packages/client/src/components/pretext/game/weaponAnimations.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ describe('weaponAnimations', () => {
expect.objectContaining({ id: 'item-iron-axe', dynamic: true }),
expect.any(Number), expect.any(Number),
expect.any(Number), expect.any(Number),
expect.objectContaining({ cellSize: 3, enable3D: true, enableGlow: true }),
expect.objectContaining({ cellSize: 4, enable3D: true, enableGlow: true }),
);
});

Expand Down
2 changes: 1 addition & 1 deletion packages/client/src/components/pretext/game/weaponAnimations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ export function drawWeapon(
// Render as ASCII at the projectile position
const size = w * 0.08;
renderMonster(ctx, template, x - size / 2, y - size / 2, size, size, {
cellSize: 3,
cellSize: 4,
enable3D: true,
enableGlow: true,
enableBgFill: false, // transparent bg — composited over battle scene
Expand Down
2 changes: 1 addition & 1 deletion packages/client/src/pages/Character.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ export const CharacterPage = (): JSX.Element => {
<CharacterViewer
race={character.race}
height={220}
cellSize={3}
cellSize={4}
equippedItems={
equippedWeapons[0]
? [{ name: equippedWeapons[0].name, socket: 'hand_R.socket' }]
Expand Down
Loading