fix: prevent double-attack animation on counterattack reveal#342
Merged
Conversation
Deploy UniRig+Blender animated spider GLB (7 clips: idle, walk, attack, hit, death, block, dodge) to client. Replaces static canvas draw with makeGLBDrawFn wrapper — canvas art remains as loading fallback. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
GLB lighting boosted (key 2.2, fill 0.6, ambient 0.4), toon gradient shadows lifted, ASCII renderer gamma/ambient/brightness cranked up. Cave background doubled: 8-13 stalactites, 6-10 stalagmites, thicker walls/ceiling/floor, boulder clusters, more interior scatter. Creature lab: fix animation seek order, update dire rat GLB. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
…e ASCII effect Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Both useBattleSceneSignals and useFloatingDamageSignals had a reset bug: their processedCountRef was reset to 0 every time visibleOutcomes changed, including when useCombatPacing revealed the counterattack after 600ms. This caused the player attack to be replayed alongside the counterattack, making it look like both sides attack simultaneously. Fix: track signaled outcomes by unique key (encounterId + turn + attackNumber + attackerId) instead of by array index. When the counterattack is revealed and visibleOutcomes grows, already-signaled outcomes are skipped. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useBattleSceneSignalsanduseFloatingDamageSignalsreplayed the player attack whenuseCombatPacingrevealed the counterattack after 600msprocessedCountRefwas reset to 0 on everyvisibleOutcomeschange, including counterattack revealTest plan
🤖 Generated with Claude Code