authentification oauth2#1578
Merged
xet7 merged 2 commits intowekan:develfrom Aug 24, 2018
salleman33:devel
Merged
Conversation
Member
|
Thanks a lot ! This is a very nice starting point for me. I would really like if I could get more pull requests for auth like this, because it is enough that it works somehow. Standalone Wekan still has only password auth integrated, and I have not got any status info about LDAP etc. |
Closed
|
Any chance to get this merged? |
Member
|
This PR needs settings added as environment variables as described in LDAP issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I wrote an oauth2 authentification patch for my organisation. It's not perfect : attributes may need to be adjust manually (username, fullname) to create a complete user profile with the right name, fullname, initials, etc.
And to take off the secret configuration from file authentification.js...
but it works ! :)
This change is