Added test config setting for skipping diffing.#1158
Merged
davidlattimore merged 1 commit intowild-linker:mainfrom Oct 7, 2025
Merged
Added test config setting for skipping diffing.#1158davidlattimore merged 1 commit intowild-linker:mainfrom
davidlattimore merged 1 commit intowild-linker:mainfrom
Conversation
Member
davidlattimore
left a comment
There was a problem hiding this comment.
Thanks for doing this. I'm wondering if we should go further and default to not diffing, then allow people to opt-in to diffing if they're running on a system where it's supported. If we do that, then we could potentially rename the option to something like enable_diff. My reason for opt-in rather than opt-out is that people packaging wild are often doing so in unusual and minimal environments and they're really just wanting to know if the way that they packaged it broke something.
Obviously for CI, we'd enable it and we'd probably recommend enabling it for people doing active development on wild.
Contributor
Author
|
Good point. I'll invert the flag. |
8b0bb73 to
c72b732
Compare
davidlattimore
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in the title. Now, when a test fails because of only a diff, text is printed indicating as much, with a pointer to how to disable diffing. This is useful for packagers and bundlers who want to check that wild, as configured, works sanely. It is also invaluable for porting wild to other unixes, as one single test setting can be used to isolate truly broken tests from differences in opinion between linkers.