feat: Support --defsym=symbol=expression#1300
Merged
lapla-cogito merged 17 commits intowild-linker:mainfrom Nov 15, 2025
Merged
feat: Support --defsym=symbol=expression#1300lapla-cogito merged 17 commits intowild-linker:mainfrom
--defsym=symbol=expression#1300lapla-cogito merged 17 commits intowild-linker:mainfrom
Conversation
lapla-cogito
commented
Nov 13, 2025
Member
davidlattimore
left a comment
There was a problem hiding this comment.
Nice to have this flag!
5bbefea to
a194878
Compare
| match def_info.placement { | ||
| SymbolPlacement::ForceUndefined => { | ||
| SymbolPlacement::ForceUndefined | SymbolPlacement::DefsymSymbol(_) => { | ||
| load_symbol_named(resources, definition_out, def_info.name, work_sender); |
Member
There was a problem hiding this comment.
Is def_info.name the right name to be loading here? I thought that was the alias and that you'd actually want to load the target symbol?
davidlattimore
approved these changes
Nov 15, 2025
lapla-cogito
added a commit
that referenced
this pull request
Nov 16, 2025
With `--defsym` support added in #1300, we can extend this to support top-level symbol definitions in linker scripts as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--defsymappears to be used in many places. Moreover, once this feature is merged, we can begin extending linker scripts further by implementing support for symbol aliases within the scripts themselves.