Sort iteration for reproducible builds#275
Open
bmwiedemann wants to merge 1 commit intowilsonzlin:masterfrom
Open
Sort iteration for reproducible builds#275bmwiedemann wants to merge 1 commit intowilsonzlin:masterfrom
bmwiedemann wants to merge 1 commit intowilsonzlin:masterfrom
Conversation
because HashMaps use random seeds to counter DoS attacks, iteration order varied in every run, which made generated attrs.rs and entities.rs non-deterministic. This patch was done while working on reproducible builds for openSUSE.
|
It's probably more efficient to replace BTreeMap is already able to outperform HashMap in some cases (for example because of better cpu cache locality with small maps), and as soon as you need deterministic output, it's likely a clear winner. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort iteration for reproducible builds
because
HashMapuses random seeds to counter DoS attacks, iteration order varied in every run, which made generated attrs.rs and entities.rs non-deterministic.See https://reproducible-builds.org/ for why this matters.
This patch was done while working on reproducible builds for openSUSE.