Fix panic for top level if and else if#19
Fix panic for top level if and else if#19RuairidhWilliamson wants to merge 3 commits intowilsonzlin:masterfrom
Conversation
|
I just implemented my own fix for this over here, https://github.com/ddotthomas/minify-js/commit/0443ef828e483f99dc4748d8d8eae4c3af80b21c I was having trouble understanding parts of the crate diving in but I thought the assert was checking that if an if statement 'returned' before that it should still be returning after being minified. Simply changing the && operator to an == one made the crate work for our project. |
Co-authored-by: ddotthomas <[email protected]>
|
Any updates on this? |
|
@wilsonzlin are you still active? Hope you're doing okay. |
|
@wilsonzlin Also hope you’re doing well! Since this crate, along with minify-html, seems unmaintained for a while, would you consider moving them into a new minify organization? I’d be happy to help maintain them, and I’m sure other community members would be willing as well. |
|
@RuairidhWilliamson or anyone interested. So with that we would suggest making this PR at our repository here: https://github.com/web-optim/jsmin/pulls Have a great day!! 🙂 |
|
Thanks for forking this @neon-mmd I am using oxc instead of this but have retargeted this PR onto your fork if you want to merge it web-optim/jsmin#2 |
Fixes #18
Hello,
This fixes two issues I found after upgrading to 0.6.0
Option::unwrap()on aNonevalue" #18I believe this will also fix the failed benchmark action on the 0.6.0 release.
Thanks for making this crate :)