[enhancement] make automaton resilient to bit flip attack#6
Merged
rben-dev merged 1 commit intowookey-project:masterfrom Aug 7, 2019
Merged
[enhancement] make automaton resilient to bit flip attack#6rben-dev merged 1 commit intowookey-project:masterfrom
rben-dev merged 1 commit intowookey-project:masterfrom
Conversation
rben-dev
suggested changes
Aug 7, 2019
Contributor
rben-dev
left a comment
There was a problem hiding this comment.
I think a local "-O0" attribute should be added to protect the "double if" statements against agressive compiler optimizations.
Contributor
Author
|
It has been added in the boitloader's Makefile, which is fully built in O0
Le 7 août 2019 08:28:19 GMT+02:00, Ryad Benadjila <[email protected]> a écrit :
…rb-anssi requested changes on this pull request.
I think a local "-O0" attribute should be added to protect the "double
if" statements against agressive compiler optimizations.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#6 (review)
|
Contributor
|
OK then! Thank you Philippe for this enhancement of the Bootloader :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.