Skip to content

Function chaining of shared types#201

Open
Mansehej wants to merge 11 commits intoyjs:masterfrom
Mansehej:chaining
Open

Function chaining of shared types#201
Mansehej wants to merge 11 commits intoyjs:masterfrom
Mansehej:chaining

Conversation

@Mansehej
Copy link
Copy Markdown
Contributor

Hey @dmonad

I've implemented function chaining in all the shared types.
I had to change the tests of y-map as they were written considering that ymap.set(key,value) returns the value itself.
Please review this PR and let me know what you think.

Regards,
Mansehej.

@Mansehej
Copy link
Copy Markdown
Contributor Author

Hey, any updates on this @dmonad?

Regards,
Mansehej.

@dmonad
Copy link
Copy Markdown
Member

dmonad commented Jun 7, 2020

Hey @Mansehej ,

sorry for coming back to you so late. So I thought about making another stable release soon but decided that I want to wait a few more months before shipping a release with breaking changes.

This is pretty unfortunate because I really like this feature ..

Anyway, thank you so much for working on this! I'll make sure that this feature is merged before the next major release.

  • Kevin

@dmonad dmonad added the next-release Will be merged in the next major release because it contains breaking changes label Jun 7, 2020
@noahcoetsee
Copy link
Copy Markdown

noahcoetsee commented Dec 8, 2021

Just as a quick question @dmonad, how much longer do you plan to wait before the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next-release Will be merged in the next major release because it contains breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants