Skip to content

Update to GTDBTK_CLASSIFYWF nf-core module#416

Merged
alxndrdiaz merged 7 commits intonf-core:devfrom
alxndrdiaz:update_gtdbtk
Apr 3, 2023
Merged

Update to GTDBTK_CLASSIFYWF nf-core module#416
alxndrdiaz merged 7 commits intonf-core:devfrom
alxndrdiaz:update_gtdbtk

Conversation

@alxndrdiaz
Copy link
Copy Markdown
Member

@alxndrdiaz alxndrdiaz commented Mar 29, 2023

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@alxndrdiaz alxndrdiaz mentioned this pull request Mar 29, 2023
Closed
@alxndrdiaz alxndrdiaz requested review from jfy133 and skrakau and removed request for skrakau March 29, 2023 17:11
@alxndrdiaz alxndrdiaz self-assigned this Mar 29, 2023
@alxndrdiaz alxndrdiaz added the enhancement New feature or request label Mar 29, 2023
@alxndrdiaz alxndrdiaz linked an issue Mar 29, 2023 that may be closed by this pull request
Update local GTDB-Tk module to newest nf-core module #409
Closed
skrakau
skrakau approved these changes Mar 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@skrakau skrakau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!
Could you update the CHANGELOG as well?

@alxndrdiaz
Copy link
Copy Markdown
Member Author

alxndrdiaz commented Mar 29, 2023

Great, LGTM! Could you update the CHANGELOG as well?

Done!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 29, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1efc5d9

+| ✅ 156 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-03-29 22:09:44

@alxndrdiaz alxndrdiaz merged commit c42c1f2 into nf-core:dev Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skrakau skrakau skrakau approved these changes

@jfy133 jfy133 Awaiting requested review from jfy133 jfy133 is a code owner

Assignees

@alxndrdiaz alxndrdiaz

Labels

enhancement New feature or request ready to review

Projects

No open projects
nf-core Hackathon March 2023
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update local GTDB-Tk module to newest nf-core module

3 participants

@alxndrdiaz @skrakau @jfy133