include COMEBin in dastool/bins output folder#907
Merged
prototaxites merged 6 commits intonf-core:devfrom Nov 3, 2025
AlexHoratio:dev
Merged
include COMEBin in dastool/bins output folder#907prototaxites merged 6 commits intonf-core:devfrom AlexHoratio:dev
prototaxites merged 6 commits intonf-core:devfrom
AlexHoratio:dev
Conversation
prototaxites
approved these changes
Oct 31, 2025
| path: { "${params.outdir}/GenomeBinning/DASTool/bins" }, | ||
| mode: params.publish_dir_mode, | ||
| pattern: '*-{MetaBAT2,MaxBin2,CONCOCT}Refined-*.fa', | ||
| pattern: '*-{MetaBAT2,MaxBin2,CONCOCT,COMEBin}Refined-*.fa', |
Contributor
There was a problem hiding this comment.
Do we need a glob at all here? Can we just have a *, as we'll be adding new binners in future?
Contributor
|
Thank you @AlexHoratio! |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just ran this pipeline, and there weren't any COMEBin bins in the
DASTool/binsfolder! All the others were there, and the .tsv summary files all listed the COMEBin bins, so DASTool definitely processed them.I'm pretty sure it's just because they didn't get included with this pattern, so weren't published. They were all present in the relevant work directory, just not the output folder.
PR checklist