Skip to content

Minor template fixes#4145

Closed
muffato wants to merge 2 commits intodevfrom
template
Closed

Minor template fixes#4145
muffato wants to merge 2 commits intodevfrom
template

Conversation

@muffato
Copy link
Copy Markdown
Member

@muffato muffato commented Mar 29, 2026

Minor template fixes to make the following PRs a (tiny) bit shorter:

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

muffato added 2 commits March 29, 2026 20:17
Some GHA variables had been introduced between the endif and the if
@muffato muffato self-assigned this Mar 29, 2026
Copilot AI review requested due to automatic review settings March 29, 2026 19:28
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes small fixes to the nf-core pipeline template GitHub Actions workflows, primarily removing unnecessary “nf-core” mentions and correcting Jinja raw-block handling so GitHub Actions expressions render correctly in generated pipelines.

Changes:

  • Fix Jinja {% raw %} / {% endraw %} placement in download_pipeline.yml so ${{ ... }} expressions aren’t emitted incorrectly.
  • Remove an unnecessary nf-core-specific reference in the branch protection workflow comment.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
nf_core/pipeline-template/.github/workflows/download_pipeline.yml Corrects raw-block boundaries and removes stray raw markers that could break rendered workflow YAML.
nf_core/pipeline-template/.github/workflows/branch.yml Updates a comment to reference the templated repo name instead of nf-core.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.47%. Comparing base (2463806) to head (d2ea5a9).
⚠️ Report is 11 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@muffato
Copy link
Copy Markdown
Member Author

muffato commented Mar 29, 2026

I think the CI error is unrelated to my change. It's complaining about module linting code.

@muffato
Copy link
Copy Markdown
Member Author

muffato commented Mar 31, 2026

@muffato muffato closed this Mar 31, 2026
@muffato muffato deleted the template branch April 3, 2026 01:10
@muffato muffato restored the template branch April 3, 2026 01:14
@muffato muffato deleted the template branch April 3, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants