Closed
Conversation
Collaborator
Author
|
closing in favor of #72, needed to merge main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit deletes the legacy implementation that was still around under
vpn/.Practically all the functionality has been moved to the public
pkg/tunnelpackage, which contains the public API now.The test binary can now be found in the same path as before,
cmd/minivpn, although the cli flags have changed. Behavior-wise, however, there are bits that I have not still ported (gvisor-based tun device). They will be ported on a per-need basis, but at least we're cleaning up the tree of the unused codebase for now.I am also bumping
go.modandgo.sum,minivpnnow requires go 1.21. This dependency could probably be relaxed (the main component that is pulling 1.21 dep now is the library I'm using to get the exit gateway, and that could be easily ported to use 1.20 or lower, but in any case 1.20 is not officially supported anymore, so I guess it's fine to start depending on 1.21 at this point).Checklist
ARCHITECTURE.md.