Skip to content

refactor: remove legacy package#71

Closed
ainghazal wants to merge 7 commits intoooni:mainfrom
ainghazal:chore/update-tree
Closed

refactor: remove legacy package#71
ainghazal wants to merge 7 commits intoooni:mainfrom
ainghazal:chore/update-tree

Conversation

@ainghazal
Copy link
Copy Markdown
Collaborator

This commit deletes the legacy implementation that was still around under vpn/.

Practically all the functionality has been moved to the public pkg/tunnel package, which contains the public API now.

The test binary can now be found in the same path as before, cmd/minivpn, although the cli flags have changed. Behavior-wise, however, there are bits that I have not still ported (gvisor-based tun device). They will be ported on a per-need basis, but at least we're cleaning up the tree of the unused codebase for now.

I am also bumping go.mod and go.sum, minivpn now requires go 1.21. This dependency could probably be relaxed (the main component that is pulling 1.21 dep now is the library I'm using to get the exit gateway, and that could be easily ported to use 1.20 or lower, but in any case 1.20 is not officially supported anymore, so I guess it's fine to start depending on 1.21 at this point).

Checklist

  • I have read the contribution guidelines
  • Iff you changed code related to services, or inter-service communication, make sure you update the diagrams in ARCHITECTURE.md.
  • Reference issue for this pull request:

@ainghazal ainghazal self-assigned this Mar 6, 2024
@ainghazal
Copy link
Copy Markdown
Collaborator Author

closing in favor of #72, needed to merge main

@ainghazal ainghazal closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant