Skip to content

refactor: remove legacy package#72

Merged
hellais merged 15 commits intoooni:mainfrom
ainghazal:chore/update-tree-2
Apr 15, 2024
Merged

refactor: remove legacy package#72
hellais merged 15 commits intoooni:mainfrom
ainghazal:chore/update-tree-2

Conversation

@ainghazal
Copy link
Copy Markdown
Collaborator

@ainghazal ainghazal commented Mar 6, 2024

Checklist

  • I have read the contribution guidelines
  • Iff you changed code related to services, or inter-service communication, make sure you update the diagrams in ARCHITECTURE.md.
  • Reference issue for this pull request:

Description

This commit deletes the legacy implementation that was still around under vpn/.

Practically all the functionality has been moved to the public pkg/tunnel package, which contains the public API now.

The test binary can now be found in the same path as before, cmd/minivpn, although the cli flags have changed. Behavior-wise, however, there are bits that I have not still ported (gvisor-based tun device). They will be ported on a per-need basis, but at least we're cleaning up the tree of the unused codebase for now.

I am also bumping go.mod and go.sum, minivpn now requires go 1.20.

@ainghazal ainghazal changed the title Chore/update tree 2 refactor: remove legacy package Mar 6, 2024
@ainghazal ainghazal mentioned this pull request Mar 6, 2024
3 tasks
@ainghazal ainghazal requested a review from hellais March 6, 2024 18:50
@ainghazal ainghazal self-assigned this Mar 6, 2024
@ainghazal ainghazal force-pushed the chore/update-tree-2 branch from 48bebdd to 89d38c6 Compare March 6, 2024 18:53
@ainghazal
Copy link
Copy Markdown
Collaborator Author

added changes to support go 1.20, as preparation to use it as a dependency from probe-cli

Copy link
Copy Markdown
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hellais hellais merged commit d8b6eb5 into ooni:main Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants