bug: propagate TLS errors as failures#73
Merged
Conversation
Collaborator
Author
b99bece to
f443e93
Compare
0d92753 to
f04fcce
Compare
Collaborator
Author
|
@hellais rebased, ready to review |
hellais
reviewed
Apr 24, 2024
| // TODO(ainghazal): pass the failure to the tracer too. | ||
|
|
||
| if errors.Is(err, ErrBadCA) { | ||
| ws.sessionManager.Failed <- session.NewFailure(err) |
Member
There was a problem hiding this comment.
Is there a reason why you need to wrap this in a special Failure struct?
Collaborator
Author
There was a problem hiding this comment.
The intention was to be able to extend it in the future for different types of failures, but you're right YAGNI for now; I'll refactor to just pass the error for now.
hellais
approved these changes
Apr 24, 2024
Member
hellais
left a comment
There was a problem hiding this comment.
I asked a clarifying question about the need to wrap stuff in a custom Failure struct, but otherwise LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For integration into probe-cli, we need to propagate any errors raised during TLS handshake.
While working on this commit, a few other improvements were made:
Checklist
ARCHITECTURE.md.