Skip to content

feat: Additional Sums for Statistics Tab#1116

Merged
MitanOmar merged 1 commit intoadfinis:mainfrom
MitanOmar:Additional-Sums-for-Statistics-Tab
Apr 8, 2026
Merged

feat: Additional Sums for Statistics Tab#1116
MitanOmar merged 1 commit intoadfinis:mainfrom
MitanOmar:Additional-Sums-for-Statistics-Tab

Conversation

@MitanOmar
Copy link
Copy Markdown
Member

@MitanOmar MitanOmar commented Mar 16, 2026

fix: #1082

todo:

  • Writing tests

@MitanOmar MitanOmar force-pushed the Additional-Sums-for-Statistics-Tab branch from 45012d2 to c2a4143 Compare March 19, 2026 13:00
@MitanOmar MitanOmar marked this pull request as ready for review March 20, 2026 21:27
@MitanOmar MitanOmar requested review from a team as code owners March 20, 2026 21:27
@MitanOmar MitanOmar requested review from derrabauke and trowik March 20, 2026 21:28
@derrabauke
Copy link
Copy Markdown
Member

waiting for #1117 -- after it got merged I will review this one

Copy link
Copy Markdown
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far, but I think it is not quite correct just yet

Comment thread backend/timed/serializers.py
Comment thread backend/timed/serializers.py
@MitanOmar MitanOmar force-pushed the Additional-Sums-for-Statistics-Tab branch from a16bcfd to 4801dab Compare March 24, 2026 21:13
Copy link
Copy Markdown
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revised one of my comments, but there's still work to do

Comment thread backend/timed/tracking/factories.py Outdated
Comment thread backend/timed/serializers.py
Comment thread backend/timed/serializers.py
@MitanOmar MitanOmar force-pushed the Additional-Sums-for-Statistics-Tab branch from 4801dab to 4a0c942 Compare March 27, 2026 01:40
Copy link
Copy Markdown
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code LGTM now. But please squash the commits and write a commit message that describes it. We don't need to have all the changes inside the PR visible in the history

@MitanOmar MitanOmar force-pushed the Additional-Sums-for-Statistics-Tab branch 2 times, most recently from 345e866 to 3ff4976 Compare April 7, 2026 00:31
@MitanOmar MitanOmar force-pushed the Additional-Sums-for-Statistics-Tab branch from 3ff4976 to 6f6b606 Compare April 8, 2026 07:52
@MitanOmar MitanOmar enabled auto-merge (squash) April 8, 2026 07:54
Copy link
Copy Markdown
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

Copy link
Copy Markdown
Member

@trowik trowik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MitanOmar MitanOmar merged commit 93930ac into adfinis:main Apr 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT]: Additional Sums for Statistics Tab

4 participants