fix: absence date faker giving weekend dates that are failing the tests#1117
Closed
MitanOmar wants to merge 1 commit intoadfinis:mainfrom
Closed
fix: absence date faker giving weekend dates that are failing the tests#1117MitanOmar wants to merge 1 commit intoadfinis:mainfrom
MitanOmar wants to merge 1 commit intoadfinis:mainfrom
Conversation
derrabauke
reviewed
Mar 17, 2026
Member
|
pls stick to conventional commit naming |
edf2281 to
6c4ff65
Compare
derrabauke
reviewed
Mar 20, 2026
derrabauke
reviewed
Mar 20, 2026
derrabauke
requested changes
Mar 20, 2026
1 task
1 task
c0rydoras
requested changes
Mar 23, 2026
45329c1 to
63a59c8
Compare
Member
|
Code LGTM; but this needs to be one commit instead of 3 |
Member
Author
it's going to be |
2fa526a to
32494f3
Compare
Member
Please squash manually and write a nice commit message, then we can merge it |
32494f3 to
58d157b
Compare
Member
Author
@winged implemented |
c0rydoras
requested changes
Apr 1, 2026
| @@ -79,6 +79,18 @@ class AbsenceFactory(DjangoModelFactory): | |||
| absence_type = SubFactory("timed.employment.factories.AbsenceTypeFactory") | |||
| date = Faker("date") | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| date = Faker("date") |
we don't need to declare date twice, otherwise lgtm
Member
Author
There was a problem hiding this comment.
@c0rydoras can you please try removing it, and running the tests ?
Collaborator
|
superseded by #1148 |
auto-merge was automatically disabled
April 2, 2026 12:35
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #1116 backend tests in CI/CD
fix: #1111 backend tests in CI/CD