feat: use textarea in comment field#1139
Merged
MitanOmar merged 5 commits intoadfinis:mainfrom Apr 10, 2026
Merged
Conversation
5e95e56 to
2555e31
Compare
Member
Author
|
Screenshots |
derrabauke
reviewed
Mar 30, 2026
c03906a to
77da4ee
Compare
MitanOmar
commented
Apr 1, 2026
71839f0 to
c449051
Compare
c0rydoras
requested changes
Apr 1, 2026
c0rydoras
requested changes
Apr 1, 2026
71ec853 to
fd80842
Compare
c0rydoras
reviewed
Apr 1, 2026
Collaborator
c0rydoras
left a comment
There was a problem hiding this comment.
I hope this makes a bit more sense
f778528 to
29e749f
Compare
c0rydoras
requested changes
Apr 7, 2026
Collaborator
c0rydoras
left a comment
There was a problem hiding this comment.
already looks a lot better! 📈 🚀
Member
Author
|
@c0rydoras i have no way with avoiding the extra classes to control the height change, except with JS code |
5be7c94 to
9f15668
Compare
Collaborator
|
@MitanOmar i described it here #1139 (comment), |
c0rydoras
previously requested changes
Apr 7, 2026
9f15668 to
d67a061
Compare
d67a061 to
4eb89b6
Compare
I did insert your proposals. As you are busy rn we (Mitan & I) take this over again. Thx for your inputs!
4eb89b6 to
967f1df
Compare
derrabauke
approved these changes
Apr 10, 2026
c0rydoras
reviewed
Apr 10, 2026
Comment on lines
+54
to
+83
| textarea.form-textarea { | ||
| @apply h-10 resize-none overflow-hidden transition-[height] duration-300 ease-in-out; | ||
| @apply focus:overflow-y-auto focus:line-clamp-none; | ||
|
|
||
| &.line-clamp { | ||
| @apply line-clamp-1 focus:line-clamp-none; | ||
| } | ||
| } | ||
|
|
||
| .content-line-1 { | ||
| /* remove line clamp on single liners */ | ||
| @apply focus:h-10 line-clamp-none; | ||
| } | ||
|
|
||
| .content-line-2 { | ||
| @apply focus:h-16; | ||
| } | ||
|
|
||
| .content-line-3 { | ||
| @apply focus:h-24; | ||
| } | ||
|
|
||
| .content-line-4 { | ||
| @apply focus:h-32; | ||
| } | ||
|
|
||
| .report-row .ember-basic-dropdown-trigger, | ||
| .report-row .form-list-cell { | ||
| @apply self-start; | ||
| } |
Member
derrabauke
added a commit
that referenced
this pull request
Apr 20, 2026
This reverts commit 415f2cc.
derrabauke
added a commit
that referenced
this pull request
Apr 20, 2026
derrabauke
added a commit
that referenced
this pull request
Apr 20, 2026
derrabauke
added a commit
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #65